pagure

Clone

#4527 reply action tweaks
Merged 4 years ago by pingou. Opened 4 years ago by jlanda.
jlanda/pagure fix-reply-action  into  master

file modified
+1 -1 
@@ -162,7 +162,7 @@ 
 

      + '    <div class="issue_actions ml-auto">'
 

      + '        <div class="issue_action icon">'
 

      + '          <div class="btn-group" role="group" aria-label="Basic example">'
 

-     + '              <a class="reply btn btn-outline-primary border-0 pointer" data-toggle="tooltip"'
 

+     + '              <button class="reply btn btn-outline-primary border-0" type="button"'
 

      + '                  title="Reply to this comment - lose formatting">'
 

      + '                <span class="fa fa-share-square-o" title="Reply to this comment"></span>'
 

      + '              </a>';

file modified
+2 -3 
@@ -159,10 +159,9 @@ 
 

  

  

              {% if g.fas_user %}
 

-               <a class="reply btn btn-outline-primary border-0 pointer" data-toggle="tooltip"
 

-                   title="Reply to this comment - lose formatting">
 

+               <button class="reply btn btn-outline-primary border-0" type="button" title="Reply to this comment - lose formatting">
 

                  <span class="fa fa-share-square-o"></span>
 

-               </a>
 

+             </button>
 

              {% endif %}
 

              {% if id != 0 and g.fas_user and (g.repo_committer or (
 

                comment.parent.status in [True, 'Open']

file modified
+1 -1 
@@ -818,7 +818,7 @@ 
 

        if (_prev.length > 0){
 

            _prev += "\n\n";
 

        }
 

-       $( "#comment" ).val(_prev + _output.join("\n"));
 

+       $( "#comment" ).val(_prev + _output.join("\n") + "\n\n");
 

        $( "#comment" ).focus();
 

      }
 

    );

Fixes the black reply icon

2 new commits added

  • comment reply: add some newlines on reply action allowing direct typing after clicking it
  • use button instead of a for comment reply button
4 years ago

rebased onto b9cec72
4 years ago

rebased onto b9cec72
4 years ago

Pull-Request has been merged by pingou
4 years ago
Changes Summary 3
+1 -1
file changed
pagure/static/issue_ev.js
+2 -3
file changed
pagure/templates/_formhelper.html
+1 -1
file changed
pagure/templates/repo_pull_request.html
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.