PR#4472: Add a missing namespace in the link to edit inline comments in PR - pagure

pagure

#4472 Add a missing namespace in the link to edit inline comments in PR

Merged 4 years ago by pingou. Opened 4 years ago by pingou.

fix_edit_inline into master

Add a missing namespace in the link to edit inline comments in PR

Pierre-Yves Chibon • 4 years ago

58e90c3

pagure/ui/filters.py

file modified

		`@@ -323,6 +323,7 @@`
		`"edit_url": flask.url_for(`
		`"ui_ns.pull_request_edit_comment",`
		`repo=comment.parent.project.name,`
		`+ namespace=comment.parent.project.namespace,`
		`requestid=comment.parent.id,`
		`commentid=comment.id,`
		`username=comment.parent.user.user`

pingou commented 4 years ago

When making an inline comment in a PR the link generated to allow
the user to edit their comment did not include the namespace.
This meant, inline comments could not be edited at all...

Fixes https://pagure.io/pagure/issue/4469

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr