The detection of parent repo in api_pull_request_create was broken - was trying to open pull request on fork. Now the pull request is opened on the parent.
Fixes #4416
Signed-off-by: Lenka Segura lenka@sepu.cz
1 new commit added
black style fixes
pretty please pagure-ci rebuild
Is it ok that I added a commit with the 4 fixed files, which were failing the test_style.py?
test_style.py
Yes but it surprises me since they do not fail for me :(
The detection of parent repo in api_pull_request_create was broken - was trying to open pull request on fork.
I think this would work but it only supports opening a PR against a parent repo, not against, for example another fork. So I wonder if we shouldn't just have a new argument: repo_from. You would then open the PR on the API of the project you want to open the PR to (so that'd be project_to) and specify in your request from which project the changes should be pulled.
What do you think?
I think the pr #4423 had the test_style failed, but I didn't check which files exactly.
Ok, I will try to do that!
Revert "black style fixes"
oops...
API: Fix the parent repo check for PR create
rebased onto 79d67979ca0e7848e0cadd76174159f212ed64c5
@lenkaseg and now it passes... :(
:thumbsup:
Thanks @ngompa, but this will be re-done completely. Just when I have conditions (long story, no computer).
Pull-Request has been closed by lenkaseg
The detection of parent repo in api_pull_request_create was broken - was trying to open pull request on fork.
Now the pull request is opened on the parent.
Fixes #4416
Signed-off-by: Lenka Segura lenka@sepu.cz