PR#4360: Add missing "line" in comments links - pagure

pagure

#4360 Add missing "line" in comments links

Merged 5 years ago by pingou. Opened 5 years ago by scfc.

scfc/pagure add-missing-line-in-comments-link into master

Add missing "line" in comments links

Tim Landscheidt • 5 years ago

b1fa8ce

pagure/templates/_formhelper.html

file modified

+1 -1

		`@@ -129,7 +129,7 @@`
		`comment.date_created \| format_datetime`
		`}}">commented`
		`{% if PRinline %}`
		`- on <a href="#c-{{ comment.commit_id }}-{{ comment.line }}"`
		`+ on line <a href="#c-{{ comment.commit_id }}-{{ comment.line }}"`
		`onclick="showTab()">{{`
		`comment.line }} of {{ comment.filename }}</a>`
		`{% endif %}`

scfc commented 5 years ago

When a user comments on a specific line of a pull request's file,
Pagure describes that à la "$user commented on 31 of Makefile 2 months
ago" with "31" referring to the line number. Prior to commit
1fa495d, this would have read "$user
commented on line 31 of Makefile 2 months ago". This commit restores
that syntax.