PR#4313: Always instantiate the status variable - pagure - Pagure.io

pagure

#4313 Always instantiate the status variable

Merged 5 years ago by pingou. Opened 5 years ago by pingou.

fix_unknown_status into master

Always instantiate the status variable

Pierre-Yves Chibon • 5 years ago

70eb4b4

pagure/lib/git.py

file modified

+1

		`@@ -2663,6 +2663,7 @@`
		`output["new_id"] = str(patch.new_id)`
		`output["old_id"] = str(patch.old_id)`
		`elif hasattr(patch, "delta"):`
		`+ status = None`
		`# Newer pygit2`
		`# we recognize non-executable file, executable file and symlink`
		`expected_modes = [33188, 33261, 40960]`

pingou commented 5 years ago

Otherwise if we end up with an unknown status, pagure blows up as the
variable is undefined.

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

rebased onto efe818f6e954adbd7102004544b638aeb1970e0d

5 years ago

rebased onto 537a26d48494c29c988340f725027b6e254d109d

5 years ago

ngompa commented 5 years ago

:thumbsup:

ngompa commented 5 years ago

instanciate -> instantiate

pingou commented 5 years ago

typo fixed :)

rebased onto 70eb4b4

5 years ago

ngompa commented 5 years ago

:thumbsup: :100:

pingou commented 5 years ago

Jenkins is all green including this last build.

Thanks for the review :)

Pull-Request has been merged by pingou

5 years ago

Metadata

Assignee

None

Tags

No Tags

Flags

Build in progress (commit: 70eb4b4d)

Build successful (commit: 70eb4b4d)

Build successful (commit: 70eb4b4d)

Build successful (commit: 70eb4b4d)

Changes Summary 1

file changed

pagure/lib/git.py

Powered by Pagure 5.13.3

Documentation • File an Issue • About • SSH Hostkey/Fingerprint

© Red Hat, Inc. and others.