PR#4304: Add a new API endpoint allowing to update an existing PR -

pagure

#4304 Add a new API endpoint allowing to update an existing PR

Merged Mar 8, 2019 by pingou. Opened Feb 28, 2019 by pingou.

update_pr into master

Download 4304.patch

pingou commented Feb 28, 2019

This endpoint allows to update the title and initial_comment of an
existing PR.

Fixes https://pagure.io/pagure/issue/4111

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

pretty please pagure-ci rebuild

Feb 28, 2019

rebased onto 9f4269821caeff5b7066b83020a8ffd1680f3855

Feb 28, 2019

rebased onto 5a90176032f5369177a96a2177d15299f13bd0e7

Mar 4, 2019

cverna commented Mar 8, 2019

In REST to update a resource you would expect to use either PUT (update all field) or PATCH (partial update). POST would be more to create a resource. but since creating a PR is different endpoint I guess that's ok ;-)

cverna commented Mar 8, 2019

:thumbsup:

pingou commented Mar 8, 2019

Something I should keep in mind for API v2 :)

pingou commented Mar 8, 2019

Thanks for the review :)

Pull-Request has been merged by pingou

Mar 8, 2019

Metadata

Assignee

None

Tags

No Tags

pagure

#4304 Add a new API endpoint allowing to update an existing PR Merged Mar 8, 2019 by pingou. Opened Feb 28, 2019 by pingou. update_pr into master

Metadata

#4304 Add a new API endpoint allowing to update an existing PR

Merged Mar 8, 2019 by pingou. Opened Feb 28, 2019 by pingou.

update_pr into master