#4171 allow any username to be searched in issues filters
Merged 7 months ago by pingou. Opened 7 months ago by ryanlerch.
ryanlerch/pagure issue4029  into  master

file modified
+6 -2

@@ -619,7 +619,9 @@ 

      labelField: 'user',

      searchField: 'user',

      maxItems: 1,

-     create: false,

+     create: true,

+     createOnBlur: true,

+     persist: false,

      load: function(query, callback) {

        if (!query.length) return callback();

        $.getJSON(

@@ -644,7 +646,9 @@ 

      labelField: 'user',

      searchField: 'user',

      maxItems: 1,

-     create: false,

+     create: true,

+     createOnBlur: true,

+     persist: false,

      load: function(query, callback) {

        if (!query.length) return callback();

        $.getJSON(

this changes the filters behaviour for the assignee and
submitter fields of the issues filters so any string can be
typed and used.

fixes #4029

Failed test:

03:49:38 Failed tests:
03:49:38 FAILED test: py-test_pagure_flask_ui_priorities

pretty please pagure-ci rebuild

7 months ago

Build 2042 passed, not sure why it didn't report it though :(

Anyway, looking good at this level, going to test it a little locally as well and if all goes fine I'll merge :)

I'm not entirely sure it fixes #4029 entirely as pressing enter does not submit the form which I think is what this ticket was about.

Waiting to hear more from you before merging then

I'm not entirely sure it fixes #4029 entirely as pressing enter does not submit the form which I think is what this ticket was about.
Waiting to hear more from you before merging then

this fixes the main issue of enter doing the wrong thing -- submitting the form with an empty string, not sure how to handle the enter to submit the form issue since it is in a dropdown. happy to merge this one, and attack the enter press next.

happy to merge this one, and attack the enter press next.

Works for me as well :)

rebased onto ac7d478

7 months ago

Pull-Request has been merged by pingou

7 months ago