PR#4056: Allow Markdown v3 for Pagure - pagure

pagure

#4056 Allow Markdown v3 for Pagure

Closed 5 years ago by ngompa. Opened 5 years ago by ngompa.

ngompa/pagure markdownv3 into master

requirements: Allow Markdown v3

Neal Gompa • 5 years ago

00d27f5

requirements.txt

file modified

+1 -1

		`@@ -14,7 +14,7 @@`
		`flask`
		`flask-wtf`
		`kitchen`
		`- markdown < 3.0`
		`+ markdown`
		`munch`
		`Pillow`
		`psutil`

ngompa commented 5 years ago

Markdown v3 is the new major version, and we should support it.

ngompa commented 5 years ago

Note that this probably doesn't work out of the box yet... I'm going to use the test run to identify what to fix. :)

ngompa commented 5 years ago

What the heck, why does every single test fail?

rebased onto 00d27f5

5 years ago

pingou commented 5 years ago

Because everything fails at the import/initiation level:

  File "/root/pagure/tests/../pagure/pfmarkdown.py", line 328, in <module>
    class ImagePatternLazyLoad(markdown.inlinepatterns.ImagePattern):
AttributeError: 'module' object has no attribute 'ImagePattern'

ngompa commented 5 years ago

I was sort of hoping those errors would be in the test runs... :(

Pull-Request has been closed by ngompa

5 years ago

ngompa commented 5 years ago

I haven't been able to work on this... Sorry, @pingou. :frowning:

Metadata

Assignee

None

Tags

No Tags

Flags

jenkins #1808

failure

Build failed (commit: 00d27f56)

5 years ago

jenkins #1807

failure

Build failed (commit: a596dd45)

5 years ago

Changes Summary 1

+1 -1

file changed

requirements.txt

pagure

Source Code

Documentation

#4056 Allow Markdown v3 for Pagure Closed 5 years ago by ngompa. Opened 5 years ago by ngompa. ngompa/pagure markdownv3 into master

Metadata

Flags

Changes Summary 1

#4056 Allow Markdown v3 for Pagure

Closed 5 years ago by ngompa. Opened 5 years ago by ngompa.

ngompa/pagure markdownv3 into master