		`@@ -136,7 +136,7 @@`
		`)`


		`- def _check_ticket_access(issue, assignee=False):`
		`+ def _check_ticket_access(issue, assignee=False, open_access=False):`
		`"""Check if user can access issue. Must be repo committer`
		`or author to see private issues.`
		`:param issue: issue object`
		`@@ -146,8 +146,11 @@`
		`"""`
		`# Private tickets require commit access`
		`_check_private_issue_access(issue)`
		`- # Public tickets require ticket access`
		`- error = not is_repo_user(issue.project)`
		`+`
		`+ error = False`
		`+ if not open_access:`
		`+ # Public tickets require ticket access`
		`+ error = not is_repo_user(issue.project)`

		`if assignee:`
		`if (`
		`@@ -824,7 +827,8 @@`
		`_check_token(repo, project_token=False)`

		`issue = _get_issue(repo, issueid)`
		`- _check_ticket_access(issue, assignee=True)`
		`+ open_access = repo.settings.get("open_metadata_access_to_all", False)`
		`+ _check_ticket_access(issue, assignee=True, open_access=open_access)`

		`status = pagure.lib.get_issue_statuses(flask.g.session)`
		`form = pagure.forms.StatusForm(`
		`@@ -938,7 +942,8 @@`
		`_check_token(repo)`

		`issue = _get_issue(repo, issueid)`
		`- _check_ticket_access(issue)`
		`+ open_access = repo.settings.get("open_metadata_access_to_all", False)`
		`+ _check_ticket_access(issue, open_access=open_access)`

		`form = pagure.forms.MilestoneForm(`
		`milestones=repo.milestones.keys(), csrf_enabled=False`
		`@@ -1125,7 +1130,8 @@`
		`_check_token(repo)`

		`issue = _get_issue(repo, issueid)`
		`- _check_ticket_access(issue, assignee=True)`
		`+ open_access = repo.settings.get("open_metadata_access_to_all", False)`
		`+ _check_ticket_access(issue, assignee=True, open_access=open_access)`

		`form = pagure.forms.AssignIssueForm(csrf_enabled=False)`
		`if form.validate_on_submit():`
		`@@ -1312,7 +1318,8 @@`
		`_check_token(repo)`

		`issue = _get_issue(repo, issueid)`
		`- _check_ticket_access(issue)`
		`+ open_access = repo.settings.get("open_metadata_access_to_all", False)`
		`+ _check_ticket_access(issue, open_access=open_access)`

		`fields = {k.name: k for k in repo.issue_keys}`
		`if field not in fields:`
		`@@ -1428,7 +1435,8 @@`
		`_check_token(repo)`

		`issue = _get_issue(repo, issueid)`
		`- _check_ticket_access(issue)`
		`+ open_access = repo.settings.get("open_metadata_access_to_all", False)`
		`+ _check_ticket_access(issue, open_access=open_access)`

		`fields = get_request_data()`

		`@@ -10,8 +10,6 @@`

		`from __future__ import unicode_literals`

		`- import sys`
		`-`
		`import sqlalchemy as sa`
		`import wtforms`

		`@@ -9,7 +9,6 @@`
		`"""`

		`from __future__ import unicode_literals`
		`- import sys`

		`import sqlalchemy as sa`
		`import wtforms`

		`@@ -630,6 +630,7 @@`
		`"notify_on_commit_flag": False,`
		`"issue_tracker_read_only": False,`
		`"disable_non_fast-forward_merges": False,`
		`+ "open_metadata_access_to_all": False,`
		`}`

		`if self._settings:`

		`@@ -160,7 +160,7 @@`
		`</div>`
		`</div>`

		`- {% if g.repo_user and not type or type == 'new' %}`
		`+ {% if (g.repo_user or open_access) and not type or type == 'new' %}`
		`<div class="col-md-4">`
		`<div class="mb-4">`
		`<h5 class="d-flex align-items-center font-weight-bold border-bottom mb-4">`
		`@@ -291,7 +291,7 @@`
		`});`
		`});`

		`- {% if g.repo_user %}`
		`+ {% if (g.repo_user or open_access) %}`
		`var available_tags = [];`
		`{% for tog in tag_list %}`
		`available_tags.push("{{ tog.tag }}");`

		`@@ -127,6 +127,10 @@`
		`close_status=repo.close_status,`
		`)`

		`+ is_author = flask.g.fas_user.username == issue.user.user`
		`+ is_contributor = flask.g.repo_user`
		`+ is_open_access = repo.settings.get("open_metadata_access_to_all", False)`
		`+`
		`if form.validate_on_submit():`
		`if flask.request.form.get("drop_comment"):`
		`commentid = flask.request.form.get("drop_comment")`
		`@@ -138,8 +142,7 @@`
		`flask.abort(404, "Comment not found")`

		`if (`
		`- flask.g.fas_user.username != comment.user.username`
		`- or comment.parent.status != "Open"`
		`+ not is_author or comment.parent.status != "Open"`
		`) and not flask.g.repo_committer:`
		`flask.abort(`
		`403,`
		`@@ -219,10 +222,7 @@`
		`# The status field can be updated by both the admin and the`
		`# person who opened the ticket.`
		`# Update status`
		`- if (`
		`- flask.g.repo_user`
		`- or flask.g.fas_user.username == issue.user.user`
		`- ):`
		`+ if is_contributor or is_author:`
		`if new_status in status:`
		`msgs = pagure.lib.edit_issue(`
		`flask.g.session,`
		`@@ -240,7 +240,7 @@`
		`# All the other meta-data can be changed only by admins`
		`# while other field will be missing for non-admin and thus`
		`# reset if we let them`
		`- if flask.g.repo_user:`
		`+ if is_contributor or is_open_access:`
		`# Adjust (add/remove) tags`
		`msgs = pagure.lib.update_tags(`
		`flask.g.session,`
		`@@ -870,6 +870,7 @@`
		`"""`
		`template = flask.request.args.get("template") or "default"`
		`repo = flask.g.repo`
		`+ open_access = repo.settings.get("open_metadata_access_to_all", False)`

		`milestones = []`
		`for m in repo.milestones_keys or repo.milestones:`
		`@@ -906,7 +907,7 @@`
		`assignee = None`
		`milestone = None`
		`tags = None`
		`- if flask.g.repo_user:`
		`+ if flask.g.repo_user or open_access:`
		`assignee = (`
		`flask.request.form.get("assignee", "").strip() or None`
		`)`
		`@@ -1038,6 +1039,7 @@`
		`types=types,`
		`default=default,`
		`tag_list=tag_list,`
		`+ open_access=open_access,`
		`)`


		`@@ -1097,6 +1099,8 @@`
		`for key in issue.other_fields:`
		`knowns_keys[key.key.name] = key`

		`+ open_access = repo.settings.get("open_metadata_access_to_all", False)`
		`+`
		`return flask.render_template(`
		`"issue.html",`
		`select="issues",`
		`@@ -1107,6 +1111,7 @@`
		`issueid=issueid,`
		`form=form,`
		`knowns_keys=knowns_keys,`
		`+ open_access=open_access,`
		`subscribers=pagure.lib.get_watch_list(flask.g.session, issue),`
		`attachments=issue.attachments,`
		`)`

		`@@ -546,7 +546,7 @@`
		`'title="comma separated list of tags"\n '`
		`'value="tag2" />', output_text)`
		`self.assertIn(`
		`- 'placeholder="username"\n value="foo" />\n',`
		`+ 'placeholder="username"\n value="foo" />\n',`
		`output_text)`
		`self.assertIn(`
		`'href="/test/roadmap/v2.0/"',`
		`@@ -1113,7 +1113,7 @@`
		`output_text)`
		`self.assertIn(`
		`'<a href="/login/?next=http%3A%2F%2Flocalhost%2Ftest%2Fissue%2F1">'`
		`- 'Login</a>\n to comment on this ticket.',`
		`+ 'Login</a>\n to comment on this ticket.',`
		`output_text)`

		`@patch('pagure.lib.git.update_git')`
		`@@ -1155,7 +1155,7 @@`
		`output_text)`
		`self.assertIn(`
		`'<a href="/login/?next=http%3A%2F%2Flocalhost%2Ftest%2Fissue%2F1">'`
		`- 'Login</a>\n to comment on this ticket.',`
		`+ 'Login</a>\n to comment on this ticket.',`
		`output_text)`

		`user = tests.FakeUser()`
		`@@ -1286,7 +1286,7 @@`
		`output_text)`
		`self.assertTrue(`
		`'<a href="/login/?next=http%3A%2F%2Flocalhost%2Ftest%2Fissue%2F1">'`
		`- 'Login</a>\n to comment on this ticket.'`
		`+ 'Login</a>\n to comment on this ticket.'`
		`in output_text)`

		`# Create issues to play with`
		`@@ -2607,7 +2607,7 @@`
		`output_text = output.get_data(as_text=True)`
		`self.assertIn(`
		`' <span class="fa fa-fw text-success fa-exclamation-circle pt-1"></span>\n'`
		`- ' <span class="text-success font-weight-bold">#1</span>\n ',`
		`+ ' <span class="text-success font-weight-bold">#1</span>\n ',`
		`output_text)`
		`self.assertEqual(output_text.count(`
		`'<option selected value="Open">Open</option>'), 1)`
		`@@ -2670,7 +2670,7 @@`
		`output_text = output.get_data(as_text=True)`
		`self.assertIn(`
		`' <span class="fa fa-fw text-success fa-exclamation-circle pt-1"></span>\n'`
		`- ' <span class="text-success font-weight-bold">#1</span>\n ',`
		`+ ' <span class="text-success font-weight-bold">#1</span>\n ',`
		`output_text)`
		`self.assertEqual(output_text.count(`
		`'<option selected value="Open">Open</option>'), 1)`

		`@@ -116,7 +116,7 @@`
		`output.get_data(as_text=True))`
		`self.assertTrue(`
		`'<a href="/login/?next=http%3A%2F%2Flocalhost%2Ftest%2Fissue%2F1">'`
		`- 'Login</a>\n to comment on this ticket.'`
		`+ 'Login</a>\n to comment on this ticket.'`
		`in output.get_data(as_text=True))`

		`user = tests.FakeUser()`
		`@@ -372,7 +372,7 @@`
		`output_text)`
		`self.assertIn(`
		`'<a href="/login/?next=http%3A%2F%2Flocalhost%2Ftest%2Fissue%2F1">'`
		`- 'Login</a>\n to comment on this ticket.',`
		`+ 'Login</a>\n to comment on this ticket.',`
		`output_text)`

		`user = tests.FakeUser()`
		`@@ -879,7 +879,7 @@`
		`output.get_data(as_text=True))`
		`self.assertTrue(`
		`'<a href="/login/?next=http%3A%2F%2Flocalhost%2Ftest%2Fissue%2F1">'`
		`- 'Login</a>\n to comment on this ticket.'`
		`+ 'Login</a>\n to comment on this ticket.'`
		`in output.get_data(as_text=True))`

		`user = tests.FakeUser()`

		`@@ -221,7 +221,7 @@`
		`output_text)`
		`self.assertIn(`
		`'<span class="fa fa-fw text-success fa-exclamation-circle pt-1"></span>\n'`
		`- ' <span class="text-success font-weight-bold">#1</span>\n',`
		`+ ' <span class="text-success font-weight-bold">#1</span>\n',`
		`output_text)`

		`def test_view_issue_author(self):`
		`@@ -238,7 +238,7 @@`
		`output_text)`
		`self.assertIn(`
		`'<span class="fa fa-fw text-success fa-exclamation-circle pt-1"></span>\n'`
		`- ' <span class="text-success font-weight-bold">#1</span>\n',`
		`+ ' <span class="text-success font-weight-bold">#1</span>\n',`
		`output_text)`

		`def test_view_issue_authenticated(self):`
		`@@ -296,7 +296,7 @@`
		`output_text)`
		`self.assertIn(`
		`'<span class="fa fa-fw text-success fa-exclamation-circle pt-1"></span>\n'`
		`- ' <span class="text-success font-weight-bold">#1</span>\n',`
		`+ ' <span class="text-success font-weight-bold">#1</span>\n',`
		`output_text)`

		`def test_view_issue_authenticated_assigned(self):`
		`@@ -320,7 +320,7 @@`
		`output_text)`
		`self.assertIn(`
		`'<span class="fa fa-fw text-success fa-exclamation-circle pt-1"></span>\n'`
		`- ' <span class="text-success font-weight-bold">#1</span>\n',`
		`+ ' <span class="text-success font-weight-bold">#1</span>\n',`
		`output_text)`

		`@@ -1698,7 +1698,7 @@`
		`index 0000000..60f7480`
		`--- /dev/null`
		`+++ b/456`
		`- @@ -0,0 +1,141 @@`
		`+ @@ -0,0 +1,143 @@`
		`+{`
		`+ "assignee": null,`
		`+ "branch": "master",`
		`@@ -1752,6 +1752,7 @@`
		`+ "issues_default_to_private": false,`
		`+ "notify_on_commit_flag": false,`
		`+ "notify_on_pull-request_flag": false,`
		`+ + "open_metadata_access_to_all": false,`
		`+ "project_documentation": false,`
		`+ "pull_request_access_only": false,`
		`+ "pull_requests": true,`
		`@@ -1809,6 +1810,7 @@`
		`+ "issues_default_to_private": false,`
		`+ "notify_on_commit_flag": false,`
		`+ "notify_on_pull-request_flag": false,`
		`+ + "open_metadata_access_to_all": false,`
		`+ "project_documentation": false,`
		`+ "pull_request_access_only": false,`
		`+ "pull_requests": true,`

		`@@ -18,7 +18,7 @@`
		`{% block repo %}`
		`<div class="d-flex align-items-start">`
		`<h4 class="ml-1">`
		`- {% if g.authenticated and g.repo_user %}`
		`+ {% if g.authenticated and (g.repo_user or open_access) %}`
		`<form action="{{ url_for('ui_ns.update_issue', username=username,`
		`namespace=repo.namespace, repo=repo.name, issueid=issueid)`
		`}}" method="post" class="hidden" id="changestatusform">`
		`@@ -34,57 +34,57 @@`
		`{{form.csrf_token}}`
		`{% if repo.issue_keys %}`
		`{% for field in repo.issue_keys %}`
		`- {% if field.key_type == 'list' %}`
		`- <select class="form-control"`
		`- name="{{ field.name }}"`
		`- id="{{ field.name \| replace(' ', '_') }}">`
		`- <option value="None">None</option>`
		`- {% for item in field.data or [] %}`
		`- <option value="{{item}}" {% if field.name in knowns_keys and item == knowns_keys[field.name].value %} selected {% endif %}>`
		`- {{ item }}`
		`- </option>`
		`- {% endfor %}`
		`- </select>`
		`- {% else %}`
		`- <input`
		`- {%- if field.key_type == 'boolean' %} type="checkbox" {% endif %}`
		`- class="form-control" name="{{ field.name }}" id="{{ field.name }}"`
		`- {%- if field.name in knowns_keys %}`
		`- {% if field.key_type == 'boolean'%}`
		`- {% if knowns_keys[field.name].value in ['true', 'on', '1'] %}checked{% endif %}`
		`- {% else %} value="{{ knowns_keys[field.name].value }}"`
		`- {% endif %}`
		`- {%- endif -%} />`
		`+ {% if field.key_type == 'list' %}`
		`+ <select class="form-control"`
		`+ name="{{ field.name }}"`
		`+ id="{{ field.name \| replace(' ', '_') }}">`
		`+ <option value="None">None</option>`
		`+ {% for item in field.data or [] %}`

pagure

Source Code

Documentation

#3846 Add option to allow any authenticated user to edit meta-data on tickets Merged 5 years ago by pingou. Opened 5 years ago by pingou. open_access_metadata into master

Metadata

Flags

Changes Summary 13

#3846 Add option to allow any authenticated user to edit meta-data on tickets

Merged 5 years ago by pingou. Opened 5 years ago by pingou.

open_access_metadata into master