PR#3601: fix weird rendering of dropdown buttons in chrome/chromium - pagure - Pagure.io

pagure

#3601 fix weird rendering of dropdown buttons in chrome/chromium

Merged 2 years ago by ryanlerch. Opened 2 years ago by ryanlerch.

ryanlerch/pagure chrome-buttons into master

fix weird rendering of dropdown buttons in chrome/chromium

Ryan Lerch • 2 years ago

e3355f9

pagure/templates/commits.html

file modified

+1 -1

		`@@ -31,7 +31,7 @@`
		`<div class="float-right">`
		`{% if branchname %}`
		`<div class="btn-group">`
		`- <a href="#" type="button" class="btn btn-outline-light border-secondary text-dark btn-sm dropdown-toggle"`
		`+ <a href="#" class="btn btn-outline-light border-secondary text-dark btn-sm dropdown-toggle"`
		`data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">`
		`<span class="fa fa-random fa-fw"></span> Branch: <span class="font-weight-bold">{{ branchname }}</span>`
		`</a>`

pagure/templates/file.html

file modified

+2 -2

		`@@ -31,7 +31,7 @@`
		`<div class="float-right">`
		`{% if branchname in g.branches %}`
		`<div class="btn-group">`
		`- <a href="#" type="button" class="btn btn-outline-light border-secondary text-dark btn-sm dropdown-toggle"`
		`+ <a href="#" class="btn btn-outline-light border-secondary text-dark btn-sm dropdown-toggle"`
		`data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">`
		`<span class="fa fa-random fa-fw"></span> Branch: <span class="font-weight-bold">{{ branchname }}</span>`
		`</a>`
		`@@ -50,7 +50,7 @@`
		`</div>`
		`</div>`
		`{% else %}`
		`- <a href="#" type="button" class="btn btn-outline-light border-secondary text-dark btn-sm"`
		`+ <a href="#" class="btn btn-outline-light border-secondary text-dark btn-sm"`
		`aria-haspopup="true" aria-expanded="false">`
		`Commit: <span class="font-weight-bold">{{ branchname }}</span>`
		`</a>`

pagure/templates/issues.html

file modified

+2 -2

		`@@ -340,7 +340,7 @@`
		`<div class="btn-group">`

		`<a class="btn btn-outline-primary btn-sm dropdown-toggle"`
		`- type="button" id="dropdownMenu1" data-toggle="dropdown"`
		`+ id="dropdownMenu1" data-toggle="dropdown"`
		`aria-haspopup="true" aria-expanded="false" href="#">`
		`<i class="fa fa-fw fa-sticky-note"></i> Reports`
		`</a>`
		`@@ -364,7 +364,7 @@`

		`{% if g.repo_admin %}`
		`<div class="list-group-item bg-light">`
		`- <a type="button" class="btn btn-primary btn-block"`
		`+ <a class="btn btn-primary btn-block"`
		`data-toggle="modal" data-target="#report_modal" href="#">`
		`Save New Report`
		`</a>`

pagure/templates/repo_info.html

file modified

+2 -2

		`@@ -128,7 +128,7 @@`
		`</div>`

		`<div class="btn-group">`
		`- <a href="#" title="{{ watch_button_title }}" type="button"`
		`+ <a href="#" title="{{ watch_button_title }}"`
		`class="btn btn-sm dropdown-toggle btn-outline-primary font-weight-bold"`
		`data-toggle="dropdown" id="watch-button">`
		`<i class="fa {{ 'fa-eye-slash' if watch_button_text == 'Watch' else 'fa-eye text-success' }} fa-fw"></i>`
		`@@ -197,7 +197,7 @@`
		`</div>`
		`</div>`
		`<div class="btn-group">`
		`- <a href="#" type="button"`
		`+ <a href="#"`
		`class="btn btn-sm dropdown-toggle btn-outline-primary font-weight-bold"`
		`data-toggle="dropdown">`
		`<i class="fa fa-users fa-fw"></i>`

pagure/templates/repo_master.html

file modified

+2 -2

		`@@ -94,7 +94,7 @@`
		`{% if g.authenticated %}`
		`<div class="btn-group">`
		`<a href="#" class="btn btn-outline-primary btn-sm dropdown-toggle"`
		`- type="button" data-toggle="dropdown"`
		`+ data-toggle="dropdown"`
		`aria-haspopup="true" aria-expanded="false">`
		`<i class="fa fa-arrow-circle-down fa-fw"></i> Open PR`
		`</a>`
		`@@ -160,7 +160,7 @@`
		`</div>`
		`{% endif %}`
		`<div class="btn-group">`
		`- <a href="#" type="button"`
		`+ <a href="#"`
		`class="btn btn-sm dropdown-toggle btn-outline-primary"`
		`data-toggle="dropdown" id="watch-button">`
		`<i class="fa fa-clone fa-fw"></i>`

pagure/templates/settings.html

file modified

+1 -1

		`@@ -244,7 +244,7 @@`
		`<strong> {{ token.description or '' }}</strong>`
		`</div>`
		`<div class="input-group-addon">`
		`- <a href="#" type="button"`
		`+ <a href="#"`
		`data-toggle="modal" data-target="#acls{{ token.id }}">`
		`{{token.acls_list_pretty\|length}} ACLs`
		`</a>`

pagure/themes/srcfpo/templates/repo_info.html

file modified

+1 -1

		`@@ -231,7 +231,7 @@`
		`</div>`

		`<div class="btn-group">`
		`- <a href="#" type="button"`
		`+ <a href="#"`
		`class="btn btn-sm dropdown-toggle btn-outline-primary font-weight-bold"`
		`data-toggle="dropdown">`
		`<i class="fa fa-users fa-fw"></i>`

ryanlerch commented 2 years ago

having the html attribute type="button" on dropdown toggles in
elements was causing chrome to render them weirdly, so this
removes all those attributes.

bkabrda commented 2 years ago

:thumbsup:

ngompa commented 2 years ago

:thumbsup:

cverna commented 2 years ago

@ryanlerch , this just need a rebase then you can merge the PR :)

rebased onto e3355f9

2 years ago

Pull-Request has been merged by ryanlerch

2 years ago

Metadata

Assignee

None

Tags

No Tags

Flags

Build successful (commit: e3355f9c)

Build successful (commit: 3759465d)

Changes Summary 7

file changed

pagure/templates/commits.html

file changed

pagure/templates/file.html

file changed

pagure/templates/issues.html

file changed

pagure/templates/repo_info.html

file changed

pagure/templates/repo_master.html

file changed

pagure/templates/settings.html

file changed

pagure/themes/srcfpo/templates/repo_info.html

Powered by Pagure 5.12.1

Documentation • File an Issue • About • SSH Hostkey/Fingerprint

© Red Hat, Inc. and others.