PR#3466: Add the build step to web run script - pagure

pagure

#3466 Add the build step to web run script

Merged 5 years ago by pingou. Opened 5 years ago by farhaan.

farhaan/pagure docker-fix into master

Add the build step to web run script

Farhaan Bukhsh • 5 years ago

44f2346

dev/docker/web-run

file modified

		`@@ -1,4 +1,5 @@`
		`#!/bin/bash -xe`
		`+ python setup.py build`
cverna commented 5 years ago I think it needs to more than just `build`. I would probably do a `develop`
pingou commented 5 years ago I actually think build should be sufficient here, since all the deps should have been installed already.
		`if [ ! -f /attachments/inited ];`
		`then`
		`echo "Giving Postgres time to start"`

farhaan commented 5 years ago

This commit adds the build step to the web run script of
docker file, this enables to resolve few dependecy problem
and have a setup in the container.

Signed-off-by: Farhaan Bukhsh farhaan.bukhsh@gmail.com

farhaan commented 5 years ago

@cverna does it look okay?

cverna commented on line 3 of dev/docker/web-run 5 years ago

I think it needs to more than just build. I would probably do a develop

cverna commented 5 years ago

I think this needs to be done for the worker and the logcom container image too, since they are importing pagure modules.

cverna commented 5 years ago

I think this needs to be done for the worker and the logcom container image too, since they are importing pagure modules.

pingou commented on line 3 of dev/docker/web-run 5 years ago

I actually think build should be sufficient here, since all the deps should have been installed already.

cverna commented 5 years ago