pagure

#3463 Update the cron job sending reminder about API key expiration
Merged by pingou. Opened by pingou.
api_key_cron  into  master

Download 3463.patch

Port it to the new code structure.
Include a --check argument allowing to see what the script will do
without sending any notification.
Increase the information returned on --debug

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

rebased onto 825a6e58f9c7ceb7231c64eb12c107388ca7dc66

Why don't we just ship systemd timers for these?

Metadata Update from @pingou:
- Request assigned

Metadata Update from @pingou:
- Request reset

Metadata Update from @pingou:
- Pull-request tagged with: RFE

Metadata Update from @pingou:
- Pull-request untagged with: RFE

We could but I don't have much experience with them, would you have a good doc for them? Do we install them via the spec file? If not, then I guess we could just mention them in the doc no?

systemd ships with a good doc on it: https://www.freedesktop.org/software/systemd/man/systemd.timer.html

It's pretty easy to write one that works for this.

rebased onto 8d3aaf6b370bf5fb5bee47ba508628b0c3e1c13b

3 new commits added

  • Fix installing the API key reminder cron with systemd integration
  • Add some documentation about cron jobs
  • Update the cron job sending reminder about API key expiration

:thumbsup:

Oh wait, hold on.

This needs to be pagure_api_key_expire_mail.timer

This needs to be pagure_api_key_expire_mail.timer

This needs to be pagure_api_key_expire_mail.timer

Also, you're missing file list entries for the pagure_api_key_expire_mail.{service,timer} files.

3 new commits added

  • Fix installing the API key reminder cron with systemd integration
  • Add some documentation about cron jobs
  • Update the cron job sending reminder about API key expiration

3 new commits added

  • Fix installing the API key reminder cron with systemd integration
  • Add some documentation about cron jobs
  • Update the cron job sending reminder about API key expiration

Wrong entries.

It should be:

%{_unitdir}/pagure_api_key_expire_mail.service
%{_unitdir}/pagure_api_key_expire_mail.timer

This needs to be .timer.

This needs to be .timer.

This needs to be .timer.

This needs to be installed as executable, or it won't run.

Wouldn't this be https://docs.pagure.org/pagure/?

rebased onto b4b0c30613e1c8c9e2dce7911a00abc4e654c38c

Your chmod +x earlier does not matter, since you're forcefully changing the mode to 644 here on install.

4 new commits added

  • Disable tests that is no longer supported
  • Fix installing the API key reminder cron with systemd integration
  • Update the cron job sending reminder about API key expiration
  • Add some documentation about cron jobs

4 new commits added

  • Disable tests that is no longer supported
  • Fix installing the API key reminder cron with systemd integration
  • Update the cron job sending reminder about API key expiration
  • Add some documentation about cron jobs

LGTM now.

4 new commits added

  • Properly install the api_key_expire_mail script with systemd integration
  • Fix installing the API key reminder cron with systemd integration
  • Update the cron job sending reminder about API key expiration
  • Add some documentation about cron jobs

rebased onto 8d3aaf6b370bf5fb5bee47ba508628b0c3e1c13b

:thumbsup: :100:

rebased onto 250f5dd6047bd3329afdcdcdd082538a9246ed52

Many thanks for your help, that PR was not my best work ^_^

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.