#3460 Drop the dependency on pygments in favor of highlight.js
Merged by pingou. Opened by pingou.
drop_pygments  into  master

Download 3460.patch
no initial comment

5 new commits added

  • Add a default log handler for PIL
  • Just a little styling clean up
  • Move the blame and file templates to use highlight.js
  • Drop the dependency on pygments everywhere it's listed
  • Drop the use of pygments

1 new commit added

  • Deprecate the FILE_SIZE_HIGHLIGHT configuration key

@pingou Do we really want to drop this? I thought we might be keeping this as a fallback for JS-free usage?

It's a good question. I am a little bit inclined to remove it entirely, the server-side highlighting has issues (you're more than aware of it) and I'm not sure how much of the new UI works w/o JS tbh.

Sounds like this is a good question for @ryanlerch. There's a good number of people who like the fact that Pagure is pretty functional without JS.

from a quick testing, all the drop-downs in the new front page are not working, the comment box looks odd due to the preview feature, I couldn't close a ticket

All the editing of metadata requires JS (I don't think this is different from now), The entire stats page also requires JS, the new settings pages as well.

So quite a few functions require JS already

rebased onto d676125f6578f522724c5fab8b1e8d51dfe122ee

rebased onto ae47ab415e9160554c2bd4db00b01afed776b07a

@pingou I think it's fine if most editing functions require JS, but if the viewing functions work, I would consider that okay...

Well, some page will no longer render correctly w/o JS I believe, independently from this PR.

This PR won't prevent any rendering, it'll just look a little less pretty.

looks good to me, +1

rebased onto 967e77e2b5c72c78a8bf4e2ccd736eb22ccb9e10

Pull-Request has been merged by pingou

Metadata