#3458 Allow colon inside tag name
Merged 2 years ago by pingou. Opened 2 years ago by netvor.
netvor/pagure colon_in_tags  into  master

file modified
+1 -1
@@ -33,7 +33,7 @@ 

  

  

  STRICT_REGEX = '^[a-zA-Z0-9-_]+$'

- TAGS_REGEX = '^[a-zA-Z0-9-_, .]+$'

+ TAGS_REGEX = '^[a-zA-Z0-9-_, .:]+$'

  FALSE_VALUES = ('false', '', False, 'False', 0, '0')

  

  WTF_VERSION = tuple()

@@ -419,7 +419,7 @@ 

          {'EVENTSOURCE_SOURCE': 'localhost.localdomain'})

      @patch('pagure.lib.notify.smtplib.SMTP')

      def test_send_email(self, mock_smtp):

-         """ Test the notify_new_comment method from pagure.lib.notify. """

+         """ Test the send_email method from pagure.lib.notify. """

          mock_smtp.return_value = MagicMock()

  

          email = pagure.lib.notify.send_email(

One example where colons are useful is when implementing debtags-like tags
(Faceted Classification). For example:

isa::bug
isa::rfe
severity::high
severity::low

The double colon here makes it easier to recognize the fact that Faceted
Classification is being used.

Related to https://pagure.io/pagure/issue/3406

rebased onto 323aec8

2 years ago

rebased onto bdadd837fd86bf1f66218a71f043c4d310e3132b

2 years ago

rebased onto 81b2c9e

2 years ago

Should we add a test for this? I can try doing it if you don't have the time :)

I'd be happy to, but you guess right; I can't promise anything in upcoming weeks.

Commit ad64a1d fixes this pull-request

Pull-Request has been merged by pingou

2 years ago

I've merged this PR and will submit tests in another :)