pagure

Clone

#3427 Ensure we are consistent about the character set allowed in tags
Merged 5 years ago by pingou. Opened 5 years ago by pingou.
allowed_tag_chars  into  master

file modified
+6 -4 
@@ -502,7 +502,8 @@ 
 

  

          return flask.redirect(flask.url_for(
 

              'ui_ns.view_settings', repo=repo.name, username=username,
 

-             namespace=repo.namespace))
 

+             namespace=repo.namespace) + '#projecttags-tab')
 

+ 

      elif flask.request.method == 'GET':
 

          tag_color = tagobj.tag_color
 

          if tag_color == 'DeepSkyBlue':
 
@@ -557,10 +558,11 @@ 
 

              if col.strip()
 

          ]
 

  

+         pattern = re.compile(pagure.forms.TAGS_REGEX, re.IGNORECASE)
 

          for tag in tags:
 

-             if '/' in tag:
 

+             if not pattern.match(tag):
 

                  flask.flash(
 

-                     'Tag: %s contains an invalid character: "/"' % tag,
 

+                     'Tag: %s contains one or more invalid characters' % tag,
 

                      'error')
 

                  error = True
 

  
@@ -648,7 +650,7 @@ 
 

  

      return flask.redirect(flask.url_for(
 

          'ui_ns.view_settings', repo=repo.name, username=username,
 

-         namespace=repo.namespace)
 

+         namespace=repo.namespace) + '#projecttags-tab'
 

      )

file modified
+1 -1 
@@ -3409,7 +3409,7 @@ 
 

                  '<title>Settings - test - Pagure</title>', output_text)
 

              self.assertIn(
 

                  ''
 

-                 'Tag: red/green contains an invalid character: &#34;/&#34;',
 

+                 'Tag: red/green contains one or more invalid characters',
 

                  output_text)
 

              self.assertIn(
 

                  '<h5 class="pl-2 font-weight-bold text-muted">Project '

Fixes https://pagure.io/pagure/issue/3406

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

1 new commit added

  • Fix a couple of redirects so the user comes back to the right tab
5 years ago

rebased onto 7186a48
5 years ago

rebased onto 9c590b89b55beba5d11a69b79622830b373dd99c
5 years ago

rebased onto fc8b3f1
5 years ago

rebased onto 9c590b89b55beba5d11a69b79622830b373dd99c
5 years ago

rebased onto fc8b3f1
5 years ago

rebased onto c1ab2bb79cdf5d92ac73ae3767249e998cf7d96e
5 years ago

rebased onto c68643cb8bc5945ed7215932ef010b8b7aeda90d
5 years ago

LGTM

rebased onto 422e36c
5 years ago

Pull-Request has been merged by pingou
5 years ago
Changes Summary 2
+6 -4
file changed
pagure/ui/issues.py
+1 -1
file changed
tests/test_pagure_flask_ui_issues.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.