|
||
|
||
|
||
|
||
|
||
pingou commented 6 years ago There is not flag involved there, what about: 'Include_diff_in_pull-request_notification' ? | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
pingou commented 6 years ago If there is no diff, this line will look odd. Should we create the body of the email, check if there is a diff and if so extent the email? | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
Added an a setting to the Project, which is responsible for whether we send a notification with or without a diff. Put maximum number of characters in email to 500000.
I didn't actually manage to send myself an email locally (I guess because there is not smtp server?), but I could see the updated emails with diff in the logs.
I'd rather we split like: