pagure

Clone

#1965 Fix inline comment not showing on first click in PR page
Merged 7 years ago by pingou. Opened 7 years ago by cep.
cep/pagure fix_inline_pr_comment_not_showing_on_click  into  master

file modified
+2 -1 
@@ -1251,7 +1251,8 @@ 
 

        $('#pr-wrapper .tab-pane').removeClass('active');
 

        // When the hash points to 'Files Changed' tab, or a highlight.
 

        if (location.hash.indexOf("request_diff") > -1 ||
 

-           location.hash.indexOf("_") === 1) {
 

+           location.hash.indexOf("_") === 1 ||
 

+           location.hash.indexOf("c-") === 1) {
 

          $('[href="#request_diff"]').addClass('active');
 

          $('#request_diff').addClass('active');
 

        }

Fixes https://pagure.io/pagure/issue/1964. More details on the
issue page.

Check by applying the patch , works for me.

Seems OK to me.

I would prefer to have the details on the commit message as well :)

Works great, let's just adjust the commit message and rebase and we're good to go :)

Since I have commit on your fork, I will adjust the commit message and rebase so this can be merged.

I hope you don't mind :-s

Pull-Request has been merged by pingou
7 years ago

@pingou thanks! I'll try to include detailed commit messages henceforth :)
Metadata
None
No Tags
Flags
jenkins #2228
success (100%)
Build successful
7 years ago
Changes Summary 1
+2 -1
file changed
pagure/templates/pull_request.html
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.