PR#1934 Merged Modified Doc Strings

Proposed 5 months ago by skarale
Modified 4 months ago
From forks/skarale/pagure develop  into pagure master

pagure/pagure/hooks/mail.py
pagure/pagure/hooks/pagure_ci.py

file changed

1 @@ -24,7 +24,7 @@ 

2   

3   

4   class MailTable(BASE):

5 -     """ Stores information about the irc hook deployed on a project.

6 +     """ Stores information about the mail hook deployed on a project.

7   

8       Table -- hook_mail

9       """
file changed

1 @@ -115,7 +115,7 @@ 

2   

3   

4   class PagureCi(BaseHook):

5 -     ''' Mail hooks. '''

6 +     ''' Continuous Integration (CI) hooks. '''

7   

8       name = 'Pagure CI'

9       description = 'Integrate continuous integration (CI) services into your '\

The change itself looks fine, but the commit message should be reworded a little I think.

The usual rule is:

  • A short description of the commit (max 72 chars)
  • An empty line
  • A longer description of the change (80 chars max per line) - optional
5 months ago

1 new commit added

  • Fixed Issue #1885: Added sign-off-by line when using web edit.

There are two different commits that are fixing two un-related issues. So I would prefer to have them into two different PRs (and the first commit still needs to have its message reworded)

There are two different commits that are fixing two un-related issues. So I would prefer to have >them into two different PRs (and the first commit still needs to have its message reworded)

I am working on the same. Once I done with removing merge conflicts, I will send two different PR.

5 months ago

1 new commit added

  • Modified Doc Strings from following files:

The commit message still needs to be reworded :(

5 months ago

rebased

@skarale why not amend the commit message and complete this PR :smile:

I'm going to merge this one manually :)

Commit f6d28c46 fixes this pull-request

4 months ago

Pull-Request has been merged by skarale @redhat.com

Changes summary
+1 -1
file changed
+1 -1
file changed