pagure

Clone

#1884 Add build_id to jenkins flag
Merged 7 years ago by pingou. Opened 7 years ago by farhaan.
farhaan/pagure jenkins-info  into  master

file modified
+3 -1 
@@ -60,11 +60,13 @@ 
 

          raise pagure.exceptions.PagureException('Request not found')
 

  

      comment, percent = BUILD_STATS[result]
 

+     # Adding build ID to the CI type
 

+     username = project.ci_hook.ci_type + " #" + str(build_id)
 

  

      pagure.lib.add_pull_request_flag(
 

          session,
 

          request=request,
 

-         username=project.ci_hook.ci_type,
 

+         username=username,
 

          percent=percent,
 

          comment=comment,
 

          url=url,

This is a PR to add build_id to the jenkins flag attached to the pull-request
jenkins in general actually didn't give much insight to what the link is pointing to
adding a build id makes it more significant to the user to which build the URL
id pointing to.

Signed-off-by: Farhaan Bukhsh farhaan.bukhsh@gmail.com

3 new commits added

  • Add alembic migration for adding build_id column
  • Change Build ID to jenkins #build_id
  • Add Build ID to the CI flag
7 years ago

How is this going to work? You first make is nullable then don't allow it anymore.

Tbh it seems to me that a much easier solution would be to include the build id in the flag name :)

  • No need to change the DB
  • No need to enforce a build ID (while maybe other systems don't have that notion)

seems to be a clean solution should have though about it :)

rebased
7 years ago

rebased
7 years ago

not valid pep8 :)

I ran a pep8 pagure/lib/lib_ci.py but I got nothing . Can you point it to me ? :)

rebased
7 years ago

Thanks :)

Pull-Request has been merged by pingou
7 years ago
Changes Summary 1
+3 -1
file changed
pagure/lib/lib_ci.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.