pagure

Clone

#1859 Fix the breaking table layout in closed issues page
Merged 7 years ago by pingou. Opened 7 years ago by rahulbajaj.
rahulbajaj/pagure TableLayout  into  master

file modified
+2 -2 
@@ -267,8 +267,8 @@ 
 

                      {{ issue.user.user }}
 

                  </a>
 

              </td>
 

-             <td class="nowrap">
 

              {% if not status or status|lower == 'open' %}
 

+             <td class="nowrap">
 

                {% if issue.assignee %}
 

                  <a href="{{ url_for('view_issues',
 

                    repo=repo.name,
 
@@ -289,8 +289,8 @@ 
 

                    assignee=0) }}">unassigned
 

                  </a>
 

                {% endif %}
 

-             {% endif %}
 

              </td>
 

+             {% endif %}
 

          </tr>
 

      {% else %}
 

          <tr>

This is adding the header for a column that only contains empty values, wouldn't make more sense to not show the column entirely?

rebased
7 years ago

I guess this would work :smile:

Good one, let's rebase and merge :)

rebased
7 years ago

Looks like it still needs a rebase :)

rebased
7 years ago

@pingou done :)

Pull-Request has been merged by pingou
7 years ago
Metadata
None
No Tags
Flags
jenkins
failure
Build failed
7 years ago
Changes Summary 1
+2 -2
file changed
pagure/templates/issues.html
Powered by Pagure 5.14.1
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.