PR#1256: Setting Mail-Followup-To when sending message to users - pagure

pagure

#1256 Setting Mail-Followup-To when sending message to users

Merged 7 years ago by pingou. Opened 7 years ago by sergiodj.

sergiodj/pagure mail-followup-to into master

Setting Mail-Followup-To when sending message to users

Sergio Durigan Junior • 7 years ago

d433ee7

pagure/lib/notify.py

file modified

		`@@ -224,6 +224,7 @@`
		`msg['Reply-To'] = 'reply+%s@%s' % (`
		`mhash.hexdigest(),`
		`pagure.APP.config['DOMAIN_EMAIL_NOTIFICATIONS'])`
		`+ msg['Mail-Followup-To'] = msg['Reply-To']`
		`try:`
		`if pagure.APP.config['SMTP_USERNAME'] \`
		`and pagure.APP.config['SMTP_PASSWORD']:`

sergiodj commented 7 years ago

I use Gnus as my MUA, and every time I get a message from pagure, I hit "F" automatically (muscle memory) in order to "reply to all". This ends up including "pagure@pagure.io" to the list of addresses that the message will be sent to. This happens because the Reply-To header is set, but the Mail-Followup-To is not. This commit fixes that.

pingou commented 7 years ago

Looks good, could you rebase on the top of master and force-push?

I try to keep the history linear :)

sergiodj commented 7 years ago

On Thursday, September 01 2016, pagure@pagure.io wrote:

pingou commented on the pull-request: Setting Mail-Followup-To when sending message to users that you are following:
``
Looks good, could you rebase on the top of master and force-push?

I try to keep the history linear :)

Oh, I thought I did that. Sorry! I'll do that :-).

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

rebased

7 years ago

pingou commented 7 years ago

Needs to be re-done every time I merge a PR as then the history changes :)

Merging, thanks! :)