PR#1219: Avoid 'Double requirements given' error when using 'pip install -r requirements.txt - pagure

pagure

#1219 Avoid 'Double requirements given' error when using 'pip install -r requirements.txt

Merged 7 years ago by pingou. Opened 7 years ago by vivekanand1101.

vivekanand1101/pagure req into master

Avoid double requirements error while running: pip install -r requirments.txt

Vivek Anand • 7 years ago

af61b71

requirements.txt

file modified

+3 -3

		`@@ -29,14 +29,14 @@`
		`trollius-redis`
		`wtforms`

		`+ # Needed only for local authentication and/or Pagure CI`
		`+ cryptography`

		# Required only for the `fas` and `openid` authentication backends
		`python-fedora`

		# Required only for the `local` authentication backend
		`- cryptography`
		`py-bcrypt`

		`- #Required for Pagure CI`
		`- cryptography`
		`+ # Required for Pagure CI`
		`python-jenkins`

no initial comment

farhaan commented on line 6 of requirements.txt 7 years ago

why not remove this instead?

vivekanand1101 commented on line 6 of requirements.txt 7 years ago

i thought: what if someone doesn't want local auth but wants to use pagure CI ? then he will either comment/remove those lines particular to local auth.

farhaan commented on line 6 of requirements.txt 7 years ago

Lets see what @pingou has to say :smile: