#1213 Include the word setting with icon
Merged 7 years ago by ryanlerch. Opened 7 years ago by tenstormavi.
tenstormavi/pagure development  into  master

@@ -199,6 +199,7 @@ 

                endif %}href="{{ url_for(

                  '.view_settings', repo=repo.name, username=username) }}">

                  <span class="oi" data-glyph="cog"></span>

+                 <span class="hidden-sm-down">Settings</span>

              </a>

            </li>

          {% endif %}

The "settings" icon is very unnoticeable and easy to miss so I have included the Setting word with the icon, such as "⚙ Settings". Fix issue no - #1204
Here is the screenshot - http://img.susepaste.org/62510346

WE just have to watch how this wraps at smaller window sizes (especially with the full set of tabs displaying) -- the wrapping issue was the primary reason for not adding the text here in the first place.

hey @tenstormavi thanks for the patch now @ryanlerch has to test this :smile:

:thumbsup: from me on this one.

@tenstormavi are you able to rebase, so I can merge this one?

rebased

7 years ago

Pull-Request has been merged by ryanlerch

7 years ago
Metadata