Learn more about these different git repos.
Other Git URLs
No commits found
This doesn't have tests yet. I will add them once the approach is approved.
The style for docstring is not following the convention.
comment convention not followed here
here
Just a suggestion , I feel you should elaborate on obj param in docstring .
obj
1 new commit added
33 new commits added
Hm, why is this needed?
I usually do not use alembic to create tables, only to modify existing ones.
For new tables I just use the existing createdb script
80 chars?
This will require a change to fedmsg_meta_fedora_infrastructure
This as well :)
I see what you mean by reading the code but not by reading the docstring. Could you expand on it?
So if there is a 4th access_level entered in the DB, the lines above will allow it but the code below basically won't do anything.
Since the code below must be adjusted for new access levels, it raises two questions:
I feel like the answer to the first question is likely yes since we use that in other places
yes
Maybe split the or_ over two lines?
or_
Since you are within brackets, you likely do not need the \
\
Pretty impressive change set, nice job!
I have a few questions but nothing major standing out.
We shouldn't forget unit-tests and docs before we merge this into master but these should be different PRs
the list should be better, will avoid a query.
I talked about this in irc. This is to get the naming convention from the model for alembic
ok, will remove this.
36 new commits added
I will update this
2 new commits added
Ok, so there was a simple comment about style, since this will not be the last PR for this feature, I'll merge this one and we can iterate based on this.
Thanks for picking this up, it's not a small one and it will be good to have it :)
Pull-Request has been merged by pingou
This doesn't have tests yet. I will add them once the approach is approved.