This doesn't have tests yet. I will add them once the approach is approved.
No commits found
1 new commit added
33 new commits added
Pretty impressive change set, nice job!
I have a few questions but nothing major standing out.
We shouldn't forget unit-tests and docs before we merge this into master but these should be different PRs
36 new commits added
2 new commits added
Ok, so there was a simple comment about style, since this will not be the last PR for this feature, I'll merge this one and we can iterate based on this.
Thanks for picking this up, it's not a small one and it will be good to have it :)
Pull-Request has been merged by pingou
Copyright © 2014-2017 Red Hat
3.3 — Documentation