PR#1120: Fix rendering release file when tag message is just whitespaces - pagure

pagure

#1120 Fix rendering release file when tag message is just whitespaces

Merged 7 years ago by pingou. Opened 7 years ago by vivekanand1101.

vivekanand1101/pagure isspace into master

Fix template rendering when tag is created with just whitespace message

Vivek Anand • 7 years ago

84f3ae5

pagure/templates/releases.html

file modified

+1 -3

		`@@ -41,8 +41,7 @@`
		`{{ tag['object'].oid \| short }}`
		`</span>`
		`</div>`
		`- {% if tag['objecttype'] == "tag" %}`
		`- {% if tag['object'].message %}`
		`+ {% if tag['objecttype'] == "tag" and tag['object'].message.strip() %}`
		`<strong>{{tag['tagname']}}</strong>`
		`{{ tag['head_msg'] }}`
		`{% if tag['body_msg'] %}`
		`@@ -50,7 +49,6 @@`
		`{{ tag['body_msg'] }}`
		`</div>`
		`{% endif %}`
		`- {% endif %}`
		`{% else %}`
		`<strong>{{tag['tagname']}}</strong>`
		`{% endif %}`

no initial comment

pingou commented 7 years ago

Took me a while but I found it:

-        {% if tag['objecttype'] == "tag" %}
-          {% if tag['object'].message %}
+        {% if tag['objecttype'] == "tag" and tag['object'].message.strip() %}
+          {% if tag['object'].message.strip() %}

And thinking of it, it makes sense :)

pingou commented 7 years ago

We could even drop the second if here