Issue #786: Should users with commit access to a repo be able to fork? - pagure

pagure

#786 Should users with commit access to a repo be able to fork?

Closed: Fixed None Opened 8 years ago by ryanlerch.

Just wondering if we should allow users with commit access to be able to fork a project -- this would allow users that also have commit access to use the same fork, PR workflow that everyone else uses, without messing up the main repo of a project with development branches.

pingou commented 8 years ago

I have always approached this as: if you have commit, create to a new branch and do PR from a branch to another in the main project.

Maybe this could be revisited.

kevin commented 8 years ago

This was just confusing to me... I kept looking for the fork button and couldn't find it (I had commit on the project).

Seems like being able to fork/do PR's the same way as everyone else would be better to me, then there's no confusing branches around in the main project.

pingou commented 8 years ago

@ryanlerch, want to do the UI change for this?

I'll take care of the backend changes if you want.

ryanlerch commented 8 years ago

So do we want this to be a blanket change? i.e. all repos now can be forked by all users?

Or do we want a setting for people to turn this on by a per-repo basis? I'm leaning towards not having another setting.

This shouldnt be too hard to fix, TBH, as i know it kinda works already (in the example of me an pagure -- i have commit access to pagure, but didnt before when i forked it.)

So it is really removing the conditionals on when we show the fork button to people.

pingou commented 8 years ago

I think the easiest is to do: everyone can fork for all the project, not on a per repo basis.

ryanlerch commented 8 years ago

Submitted a PR for this:
https://pagure.io/pagure/pull-request/834

pingou commented 8 years ago

Fixed by @ryanlerch in the PR mentioned above :)