Learn more about these different git repos.
Other Git URLs
Pagure's OIDC login method is now broken because flask-oidc doesn't work with the latest Flask+Werkzeug releases. There's an upstream ticket.
Additionally, there are PRs piling up with useful/necessary fixes. I suspect @puiterwijk hasn't had time to look at it anymore.
@abompard has been wanting to move Fedora's Pagure instances to OIDC, but I might need to rip out our OIDC support if we don't have a plan to deal with flask-oidc.
I was alerted to this situation from the openSUSE folks, who are trying to remove flask-oidc from openSUSE because of this issue.
What are we going to do?
@pingou, what do you think?
Hey Neal! This quarter we have started an initiative to migrate flask-oidc to use authlib under the hood, while keeping the same API. It should solve this issue.
Related issue: https://pagure.io/pagure/issue/5401
I'm willing to implement it, but it's unclear to me if authlib or the flask-oidc fork from fedora infra is preferred, see my comment in the related ticket:
authlib
flask-oidc
@abompard mentioned here https://pagure.io/fedora-infrastructure/issue/10372#comment-870505 that there is an authlib based flask-oidc package now. I assume it's the fork https://github.com/fedora-infra/flask-oidc/. I wonder what is now the preferred way for Pagure @zlopez @ngompa ? Using the fedora infra managed flask-oidc fork or migrating to plain authlib? Would be nice to clarify that before I start to work on it ;)
Metadata Update from @wombelix: - Issue set to the milestone: 6.0
Log in to comment on this ticket.