#5166 Magic word "Relates" doesn't seem to work correctly
Opened 2 years ago by praiskup. Modified a year ago

I opened a pull request and I expected that Pagure will match the new PR with the issue as I noticed the issue in two commits using the "Relates: #ID" syntax.


I opened a pull request and I expected that Pagure will match the new PR with the issue as I noticed the issue in two commits using the "Relates: #ID" syntax.

It should, once the PR is merged

That would behave differently from "Fixes", though. https://pagure.io/copr/copr/pull-request/1841 updated the two mentioned issues right when the PR was opened.

Metadata Update from @wombelix:
- Issue assigned to wombelix

a year ago

@praiskup I guess you mean that if you use Fixes then the PR will be mentioned in the Issue, on the right side as RELATED PULL REQUESTS, immediately?

And If I understand correctly, @pingou was referring to an actual comment which will created in the related issue as soon the PR was merged.

Affected file: https://pagure.io/pagure/blob/master/f/pagure/lib/tasks.py
Affected function: link_pr_to_ticket

As far I can see, the behavior for fixes and relates is identical, there is a loop for fixes in https://pagure.io/pagure/blob/master/f/pagure/lib/tasks.py#_1101 and one for relates in https://pagure.io/pagure/blob/master/f/pagure/lib/tasks.py#_1112

I created a test project with two issues and one pr:
https://pagure.io/wombelix_testprj/pull-request/3
https://pagure.io/wombelix_testprj/issue/2
https://pagure.io/wombelix_testprj/issue/1

Commit Message:

    test.txt changed

    Fixes: https://pagure.io/wombelix_testprj/issue/2
    Relates: https://pagure.io/wombelix_testprj/issue/1

As expected, both issues got linked to the PR, as soon I pushed it RELATED PULL REQUESTS showed up with a link to PR 3.

So for me it looks like that it works as designed?

@praiskup can you please confirm if the problem still exist for you and give an recent example of it or explain how to reproduce? As mentioned above, based on verifying the source code and doing some testing, I have the impression that everything is fine and this Issue can be closed.

Login to comment on this ticket.

Metadata