#5162 When I click [Merge v] button, nothing happens.
Closed: Duplicate 2 years ago by pingou. Opened 2 years ago by stefw.

In my pull request on src.fedoraproject.org, I click the Merge button and nothing happens. A small green menu appears below the Merge button. Will attach a screencast of the issue.

To reproduce:

  1. Go to https://src.fedoraproject.org/rpms/oci-kvm-hook/pull-request/2#
  2. Click [Merge]

Expected results:

  • The pull request is merged

Buggy results:

  • Nothing happens, just a green menu.

Thanks for the help! The the "File an Issue" link at the bottom of src.fedoraproject.org footer links here, so that's why I'm filing a request in this repository.


Once I'm able to get past this Pagure bug, I'll be able to merge my fix:

https://src.fedoraproject.org/rpms/oci-kvm-hook/pull-request/2#

The fix is for a FTBFS on the Fedora oci-kvm-hook package.

https://bugzilla.redhat.com/show_bug.cgi?id=1923637

FYI @churchyard ... CC'ing you because I know I've been tardy on the above bug ^^ sorry.

The issue is that you do not have commit there, this package is orphaned: https://src.fedoraproject.org/rpms/oci-kvm-hook

The UI is confusing for this, I agree

Looking at the left hand-side column, I see: Orphaned for: Fails to build from source -- Fails to build from source

So you may have to adopt the package again before being able to merge that PR :)

This is a dupe of https://pagure.io/pagure/issue/4768 -- when you don't have permissions, the button is really confusing.

To get the permissions, un-orphan the package by clicking the Take button in the left hand-side column.

Indeed. The FTBFS was because golang rebased without fixing the all packages it broke by doing so. In any case, I'll figure out to adopt the package again.

The package now seems to be assigned back to you.

It looks like the PR was merged and since the UI issue is tracked in #4768 I'm going to close this ticket as duplicate of that one.

Sorry for the inconvenience!

Metadata Update from @pingou:
- Issue close_status updated to: Duplicate
- Issue status updated to: Closed (was: Open)

2 years ago

Thanks for helping me troubleshoot this one.

Login to comment on this ticket.

Metadata
Attachments 1