#4840 milter crashes with python3 pagure-milters-5.9.1
Closed: Fixed 3 years ago by pingou. Opened 3 years ago by kevin.

on pagure-stg01:

Apr 30 16:35:06 pagure-stg01.fedoraproject.org python3.6[851]: Traceback (most recent call last):
Apr 30 16:35:06 pagure-stg01.fedoraproject.org python3.6[851]:   File "/usr/lib64/python3.6/site-packages/Milter/__init__.py", line 772, in <lambda>
Apr 30 16:35:06 pagure-stg01.fedoraproject.org python3.6[851]:     milter.set_eom_callback(lambda ctx: ctx.getpriv().eom())
Apr 30 16:35:06 pagure-stg01.fedoraproject.org python3.6[851]:   File "/usr/share/pagure/comment_email_milter.py", line 133, in eom
Apr 30 16:35:06 pagure-stg01.fedoraproject.org python3.6[851]:     msg = email.message_from_file(self.fp)
Apr 30 16:35:06 pagure-stg01.fedoraproject.org python3.6[851]:   File "/usr/lib64/python3.6/email/__init__.py", line 54, in message_from_file
Apr 30 16:35:06 pagure-stg01.fedoraproject.org python3.6[851]:     return Parser(*args, **kws).parse(fp)
Apr 30 16:35:06 pagure-stg01.fedoraproject.org python3.6[851]:   File "/usr/lib64/python3.6/email/parser.py", line 57, in parse
Apr 30 16:35:06 pagure-stg01.fedoraproject.org python3.6[851]:     feedparser.feed(data)
Apr 30 16:35:06 pagure-stg01.fedoraproject.org python3.6[851]:   File "/usr/lib64/python3.6/email/feedparser.py", line 175, in feed
Apr 30 16:35:06 pagure-stg01.fedoraproject.org python3.6[851]:     self._input.push(data)
Apr 30 16:35:06 pagure-stg01.fedoraproject.org python3.6[851]:   File "/usr/lib64/python3.6/email/feedparser.py", line 103, in push
Apr 30 16:35:06 pagure-stg01.fedoraproject.org python3.6[851]:     self._partial.write(data)
Apr 30 16:35:06 pagure-stg01.fedoraproject.org python3.6[851]: TypeError: string argument expected, got 'bytes'

This is just sending from localhost:

Apr 30 16:35:08 pagure-stg01 postfix/pickup[9408]: BB56C108989E: uid=0 from=<root>
Apr 30 16:35:08 pagure-stg01 postfix/cleanup[9409]: BB56C108989E: message-id=20200430163508.BB56C108989E@pagure-stg01.fedoraproject.org
Apr 30 16:35:08 pagure-stg01 postfix/cleanup[9409]: BB56C108989E: milter-reject: END-OF-MESSAGE from localhost[127.0.0.1]: 4.3.0 pymilter: untrapped exception in paguremilter; from=root@stg.pagure.io to=kevin@fedoraproject.org


Metadata Update from @pingou:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #4843 Closed 3 years ago