Learn more about these different git repos.
Other Git URLs
When there is a pull request I cannot mere, the merge button looks broken instead of disabled:
<img alt="png" src="/pagure/issue/raw/files/72ff8109bc724220517ca27a53235ce896f80bd387812fc611c8ed0ee869721b-png" />
<img alt="png" src="/pagure/issue/raw/files/1df42e5aa7ae087a586080e53d0c573b0aeef7f18ed2bdf62f9c8e9375a8a5da-png" />
Metadata Update from @pingou:
- Issue tagged with: JS, UI, bug
More than that, it really makes me want to push it. It's made of gold!
Honestly IMHO the sensible thing would be not to show a Merge button at all, unless merging is an action that's available to the user.
e.g. at GitHub, when I can merge a PR:
<img alt="Screenshot_from_2020-03-22_06-06-25.png" src="/pagure/issue/raw/files/96b321ceff4904a2655cee5bec50d82655920dd5a1c94952a329173b9e7794aa-Screenshot_from_2020-03-22_06-06-25.png" />
And when I can't:
<img alt="Screenshot_from_2020-03-22_06-06-05.png" src="/pagure/issue/raw/files/07f35c2074a036c88dd3d3f19dfc08f0fb7412e2fe0594f5e6c9484e0e4aff8d-Screenshot_from_2020-03-22_06-06-05.png" />
Note the merge button currently also hides "rebase" if enabled for the user, so it cannot just be removed (unless we move the rebase action elsewhere).
Which actually would be a good thing, because I had no idea there was a Rebase button inside the merge button! (Hey, I said it makes me want to push it, not that I've actually pushed it.) I don't think I'd ever have learned that, on my own.
to comment on this ticket.