#4588 500 when commit diff is empty
Closed: Fixed 4 years ago by jlanda. Opened 4 years ago by msrb.

I have a commit with no changes:

https://pagure.io/msrb-test/c/3c95866d004e84b2656d323f05173fa818db2375?branch=master

It was created with git commit --allow-empty -m "empty diff".

Pagure returns 500 when I try to access the raw diff via following URL: https://pagure.io/msrb-test/c/3c95866d004e84b2656d323f05173fa818db2375.diff


Metadata Update from @jlanda:
- Issue tagged with: bug

4 years ago

What shall we do here? 404 with uo templating? 200 and empty body? 204? I prefer 204 but I wpuld like to know what others think about

200 and empty body, IMO. That doesn't lead to unexpected surprises when trying to view a commit.

200 and empty body,

wfm

Metadata Update from @pingou:
- Issue tagged with: easyfix

4 years ago

Metadata Update from @jlanda:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

4 years ago

Login to comment on this ticket.

Metadata