#4513 Jenkins integration should add comment or otherwise trigger notification
Opened 2 months ago by sgallagh. Modified 2 months ago

Right now, when using Jenkins integration for performing CI checks on a pull request, there is no feedback to the submitter of the PR unless they think to go check for it some time later.

Problems:

  1. There's no indication that CI runs have been started. You only see the results once they end (which may be minutes or hours later).
  2. There's no notification emitted on the completion of the CI run, so a new contributor will have no reason at all to think that they might need to go and manually check the results.

For example: https://pagure.io/releng/fedora-module-defaults/pull-request/123

I have CI that verifies that the YAML documents being modified meet Fedora policies. As the reviewer, I know that I need to check the CI results, but this leads to a much longer round-trip time since I have to add a comment informing the contributor that their submission didn't pass the tests.


There's no indication that CI runs have been started. You only see the results once they end (which may be minutes or hours later).

This is a jenkins settings, pagure supports it. You need to ask jenkins to notify pagure at the start and end of the run.

There's no notification emitted on the completion of the CI run, so a new contributor will have no reason at all to think that they might need to go and manually check the results.

There is a settings per project to notify on PR flags which is what CI systems will use.

There is a settings per project to notify on PR flags which is what CI systems will use.

This is "Notify on pull-request flag" on the "Project options" page? If so... that really needs a better description. Also it would be sensible to have a note about it on the "Pagure CI" hook setup.

This is "Notify on pull-request flag" on the "Project options" page? If so... that really needs a better description.

It is yes :)

Also it would be sensible to have a note about it on the "Pagure CI" hook setup.

Let's make this ticket about this then :)

Metadata Update from @pingou:
- Issue tagged with: doc, easyfix

2 months ago

Login to comment on this ticket.

Metadata