#4500 Clicking 'reply' button on a comment doesn't jump to the text box or in any other way indicate it worked
Closed: Fixed 2 years ago by jlanda. Opened 2 years ago by adamwill.

When you click on the reply button to a comment on a pull request...nothing at all appears to happen. (At least not for me, using Firefox on Rawhide with ublock origin and umatrix, but no JS seems to be being blocked). At first I thought it was broken, but it isn't, it works 'fine', by populating the actual text entry box for the next comment with the quoted text of the comment whose reply button you clicked. But it doesn't indicate to you in any way that it has done this - there's no visual feedback at all if the text entry box isn't actually visible on screen when you hit the button. Because there's no indication that this has happened, you may just give up, or keep hitting the button, which seems to keep appending the text to the box over and over...


just scrolling you to the filled box will work?

Metadata Update from @pingou:
- Issue tagged with: JS, bug

2 years ago

this is
a missing .focus() call somewhere

Metadata Update from @jlanda:
- Issue tagged with: easyfix

2 years ago

Metadata Update from @jlanda:
- Issue assigned to jlanda

2 years ago

Metadata Update from @jlanda:
- Issue set to the milestone: 5.7

2 years ago

Fixed on 5.7 and enhanced on #4527

Metadata Update from @jlanda:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #4519 Merged 2 years ago