#4464 Sorting PRs by "last modified" renders wrong order
Opened 4 months ago by mhonek. Modified 18 days ago


Metadata Update from @pingou:
- Issue tagged with: bug

4 months ago

I need some help with this one @pingou .

PullRequest object has both updated_on and last_updated column. Ordering, is based on last_updated . The one we are rendering on PR list on the "Modified x hours ago" line is updated_on.

adding a comment on the pr, udpates updated_on, while editing that comment updates last_updated . So this is a mess and quite hard to understand what's going on.

Before proceeding, what's the idea with this two columns? Is one for the PR itself's updates and the other a general one that includes it's associated comments? If so, who is who?

And what is the intent when ordering by last_updated, ordering by PR's update time, or their comment's update time?

Thanks in advance

PullRequest object has both updated_on and last_updated column. Ordering, is based on last_updated . The one we are rendering on PR list on the "Modified x hours ago" line is updated_on.

So we likely want to change the ordering to use updated_on (we may want to update that field when the PR is flagged, which we don't do apparently atm).

adding a comment on the pr, updates updated_on, while editing that comment updates last_updated

last_updated won't get updated on editing/adding a comment as these actions won't touch the pull_requests table, so I'm wondering if, for these actions, we shouldn't update both last_updated and updated_on.

Login to comment on this ticket.

Metadata