Learn more about these different git repos.
Other Git URLs
Currently pagure/templates/_render_repo.html ends its success function for the activity lookup with:
pagure/templates/_render_repo.html
success
if (data.activities.length > 0){ // ... else { $('#user-activity-body').append( '<div class="list-group-item">No activity recorded on that day</div>' ); }
With that .append() being a bit too effective, because every time you click on a day with no activity, an additional "No activity recorded on that day" message is added below the existing one(s), growing the list ever longer.
.append()
Worse, those messages aren't cleared out even when a day with activity is clicked on, nor does closing the Activity list using the × in the upper-right corner — the built up "No activity..." lines return when the list reappears. Only reloading the page flushes out the list.
With just a few strategic clicks around the (rare) non-active days on the user activity map for @pingou I was left with an Activity list in this state:
<img alt="Screenshot_from_2019-04-15_18-35-10.png" src="/pagure/issue/raw/files/08b98fbfb0a50c6ba06d073921435df0433a4b8d8568dd0c4947fc3bd03908af-Screenshot_from_2019-04-15_18-35-10.png" />
This should be fairly easy to fix, especially since you've already looked at where the code for this is :)
Would you like to take a stab at fixing it? You can open a PR or attach a patch to this ticket, either work for me :)
Metadata Update from @pingou: - Issue tagged with: JS, bug, easyfix
Sure, but I'm shooting blind because the hour I just spent trying and failing to get vagrant working is as much as I care to spend on it, so it'll be completely untested.
Commit 86ae8f5 fixes this issue
Login to comment on this ticket.