pagure

Clone

#438 not clear my work isn't saved when editing online and not filling out the commit
Closed: Fixed None Opened 8 years ago by mattdm.

Closed: Fixed
Reopen Issue

If you edit online and leave the commit message blank, or just fill out the lower details field but leave the top line empty, you can press "commit" but you're taken back to the same page, uncommitted.

Something should make this more clear... gray out the commit button if there's no message? Give a warning? Or, juts accept the shaded default text if a message isn't given?

I think the easiest (and neatest) fix here would be to

  1. replace the placeholder text in the commit message textbox with the same text but as text. It can be edited, but most will leave it as is though.

The other option is to have
2. some form of client-side validation to ensure that the field is filled out before submitting the form.

cheers,
ryanlerch

Submitted a PR for the first option:

https://pagure.io/pagure/pull-request/565

Merged

Login to comment on this ticket.

Metadata

0.2

None
None
None
None
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.