#4329 Filtering user issues by close date does not work
Opened 5 years ago by psss. Modified 5 years ago

In #4064 a new parameter closed has been introduced to allow filtering based on the close date of the issue but it seems the parameter does not work as expected. Issue closed in given time frame are not correctly included and there are some additional issues which should not be reported. Example query:


Metadata Update from @pingou:
- Issue tagged with: bug

5 years ago

Similarly filtering by close date does not work for closed pull requests:

Note that the filter returns objects even for date range in the future.

@pingou, just to be sure: Is the requests/actionable with status=all the right way how to query for pull requests closed/merged by given user? Or is there a better way? Thanks.

Is the requests/actionable with status=all the right way how to query for pull requests closed/merged by given user?

It will return you the PR an user is able or was able to close/merge. That won't mean all the PR returns have been closed/merged by that user.

For example a PR on pagure merged by @cverna would still appear on this API endpoint for me.

It will return you the PR an user is able or was able to close/merge. That won't mean all the PR returns have been closed/merged by that user.

A follow up thought I just had, the data returned is based on the permission at the time of the request I believe.
So to use the same example, if I was to give pagure to someone else, this API endpoint would not return all the PR that I have merged in the pagure project.

Thanks for clarification. Would it make sense to introduce a new API endpoint user/assigned which could be used to query all issues/pull requests assigned to given user? Or what best way would you recommend to get the list of assigned issues/pull requests closed in given timeframe?

Yes for issues that works well. I mean this way of query but filtering itself is broken. But what do we do for pull requests? Could it be similar? Or adding assinged?

Or something similar to what github has?

search/issues?q=assignee:{login}+closed:{since}..{until}+type:pr

I mean this way of query but filtering itself is broken.

I'm confused on this.

Let's try to fix one issue at a time, I fear we're speaking past each other because we're on two topics at once :)

Sorry, I haven't noticed this is a different url. Omitting author=false does not help.

https://pagure.io/api/0/user/psss/issues?status=all&closed=2019-03-07..2019-03-08

Issue 28 mentioned in the ticket description is still not listed and there are extra issues which should not be present.

Login to comment on this ticket.

Metadata