Learn more about these different git repos.
Other Git URLs
I tried below markdown for both GitHub and Pagure.
Markdown sample https://gist.github.com/junaruga/28efa9c914e0e4e831da47fa4bf6afe0
GitHub https://github.com/junaruga/github-markdown/blob/master/resources/github_markdown.png
Pagure https://github.com/junaruga/github-markdown/blob/master/resources/pagure_fedora_markdown.png
I prefer block of code's background color is gray like GitHub. And right now margin-buttom of the block of code is zero. This is uncomfortable.
margin-buttom
Maybe ./pagure/static/pagure.css pre (block of code), blockquote (citation) parts can be better for that.
./pagure/static/pagure.css
pre
blockquote
There is a way to check GitHub CSS.
$ npm install generate-github-markdown-css $ ./node_modules/.bin/github-markdown-css > github-markdown.css
And here is the sample html I prepare with the GitHub CSS. https://github.com/junaruga/github-markdown/blob/master/sample.html
This is already fixed in master for 5.2, I believe.
This is how it looks in git currently:
<img alt="Screenshot_from_2018-11-26_16-03-17.png" src="/pagure/issue/raw/files/f21738bc07d12f48a516b53d1469ad633b4a00078efd04e35a7f7d42280516cd-Screenshot_from_2018-11-26_16-03-17.png" />
Does this suit you?
Thanks for the info. Nice! Gray background color!
But it seems that the latest code of block (pre) is still margin-buttom: 0. It need space between bottom of the code block and the text "Citation test".
margin-buttom: 0
And I think blockquote's padding-top: N and padding-buttom: N is too big comparing with Github markdown html.
padding-top: N
padding-buttom: N
GitHub as a reference. <img alt="screenshot-github.com-2018.11.21-17-29-02.png" src="/pagure/issue/raw/files/eb4b98577a2c7a9906c759808a3e5a05a10526d37b41e49eeff1aab5e65e3cbf-screenshot-github.com-2018.11.21-17-29-02.png" />
Would you like to work on a PR for this? :)
Well, I get in vacation from tomorrow until Sunday. After coming back, I might look at it. But do not expect it :)
I can work now for that. Just moment.
I sent PR: https://pagure.io/pagure/pull-request/4069 Please review it. Thank you.
Commit 3e8c63f fixes this issue
Metadata Update from @pingou: - Issue assigned to jaruga - Issue set to the milestone: 5.2 - Issue tagged with: RFE
Login to comment on this ticket.