#4019 Unable to set minimum score required for pull requests
Closed: Fixed 6 months ago by pingou. Opened 8 months ago by wattersmt.

I just noticed that the project options page does not allow a score to be set when I enable this option. Attached is a screenshot.

Screenshot_from_2018-11-16_15-57-02.png

As you can see there is no input field to set a value.


This is most odd, it should show an input box instead of a checkbox.
Does it happen on all project or just some?
Did you set/unset it in the past?

Metadata Update from @pingou:
- Issue tagged with: bug

8 months ago

@pingou This happens on all projects. The default score appears to be -1 as shown in the following screenshot.

Screenshot_from_2018-11-19_08-22-59.png

Changing the score works on the first attempt however the option is disable after being set to 0.

Screenshot_from_2018-11-19_08-25-34.png

Ok, so the issue is with the value 0 (note that -1 means: no default score, it'll be the same thing as 0)

Ok, so the issue is with the value 0 (note that -1 means: no default score, it'll be the same thing as 0)

The same issue occurs after setting the value to 1.

Does it happen only on 0 and 1 or also with 2, 5, 10, -1?

Metadata Update from @pingou:
- Issue set to the milestone: 5.3

7 months ago

Metadata Update from @pingou:
- Issue assigned to pingou

6 months ago

I could reproduce this one, I have the fix for it :)

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #4180 Merged 6 months ago