#3977 update_git task fails if repo has pagure_no_new_branches hook active
Closed: Fixed 5 years ago Opened 5 years ago by bkabrda.

Updating the requests repo through update_git task fails, if there is pagure_no_new_branches hook active on the repo. The reason for this is that the new-style hooks are attached not just to the main repo, but also to requests, tickets and docs repos. I think this shouldn't be the case.

There are two solutions that come to my mind:

  • only run the Default hook for non-main repos
  • allow every hook to specify for which repos it should be run

I'd probably prefer the first solution since I don't see a usecase for the second one ATM, but maybe someone else does. WDYT?


only run the Default hook for non-main repos

The pagure-tickets and pagure-requests hooks need to run on their own repo.

A number of hooks are already checking on which repo they run

Ah, ok. So I guess it'd make most sense to do a check in the no_new_branches hook to make sure it only runs on the main repo.

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #3979 Merged 5 years ago