Learn more about these different git repos.
Other Git URLs
For Koji, we rely on the Pagure hook to close our pull requests and related issues. It appears that this is not working. The changes I just pushed can be seen here:
https://pagure.io/koji/c/175e6f2d3c9fca80837d314aa848b523fee5d869?branch=master
This merge commit includes the lines: Merges #1123 and Fixes: #1112
Merges #1123
Fixes: #1112
However, neither PR #1123 nor Issue #1112 was closed by the hook. The Pagure hook is enabled for Koji and has been for some time.
It happens that I still have the push output on my console. I don't see any output from the hook. Could it have been lost in the most recent update?
[mike@localhost koji]$ git push Counting objects: 1, done. Writing objects: 100% (1/1), 342 bytes | 342.00 KiB/s, done. Total 1 (delta 0), reused 0 (delta 0) To ssh://pagure.io/koji.git abf0f716..175e6f2d master -> master [mike@localhost koji]$
Metadata Update from @pingou: - Issue tagged with: bug
I fixed this server side, somehow it seems your project's hook had not been upgraded (I wonder if this is not because the project was created in the early days of pagure). I'll put a note to myself to double-check this for all projects.
Thanks for the report :)
Metadata Update from @pingou: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
thanks!
Login to comment on this ticket.