#3879 redraw error, deleted tags don't disappear
Closed: Fixed 5 years ago Opened 5 years ago by bex.

I updated a ticket's metadata and removed a tag (the only tag). I did not click update though, instead I also added a comment and hit the comment button below the comment box. The tag was removed and the comment was added, however the screen redraw still showed the tag. A refresh caused it to disappear.


however the screen redraw still showed the tag

I suspect the screen didn't redraw which is why the tag was still showing.

This is likely the results of the change we pushed in 5.1 where if the SSE isn't working/responding, we're sending the form via ajax and showing the comment via JS, so if there is more than just the comment in the form, we're not showing these changes.
I think we should check if the user is sending something else than just a comment and based on that either do everything in JS or get them to go the old http request way :)

Metadata Update from @pingou:
- Issue set to the milestone: 5.2
- Issue tagged with: JS, bug

5 years ago

I'm basically going to revert this change, if the SSE is down or not responding, we'll go back to sending a full/regular http request.

Metadata Update from @pingou:
- Issue assigned to pingou

5 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #4061 Merged 5 years ago