#3818 PR can't be merged if source fork deleted
Closed: Fixed 5 years ago Opened 5 years ago by bkabrda.

I stumbled upon a situation in the Pagure instance that I'm running where a user created a PR from a fork and then deleted that fork. This resulted in the PR not being mergeable (does the word "mergeable" exist? :)) because the /pv/pull-request/ready failed to process it.

I'm not sure how to best handle this situation, perhaps all PRs should be closed when the source fork is deleted (and user should be warned that deleting the fork will do that)? Or do we want to fix this so that the PR can be merged even if the fork was deleted?


Or do we want to fix this so that the PR can be merged even if the fork was deleted?

Since we store the head of the PR in refs/pr/<id> we should be able to make this work (and I thought it was working tbh)

Metadata Update from @pingou:
- Issue set to the milestone: 5.2
- Issue tagged with: bug

5 years ago

@bkabrda It is true that we can't merge a PR once the forked repo is deleted and it is the way it should be. I guess the PR should automatically close once the fork is deleted.

it is the way it should be.

Why do you think so?

Metadata Update from @pingou:
- Issue assigned to pingou

5 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #4116 Merged 5 years ago