#3605 PR link in a fork returns wrong URL when PR already exists
Closed: Fixed 2 months ago by pingou. Opened 6 months ago by sharkcz.

I made changes to the fedora-release package and created a "s390x" branch in my fork (https://src.fedoraproject.org/fork/sharkcz/rpms/fedora-release). I opened a new PR using the web UI with the "PR" button right from the branch name. After visiting the fork again, it shows a green button for the "s390x" branch with "PR#rpms/fedora-release/pull-request/22 " as label. Clicking on the button gives "https://src.fedoraproject.org/rpms/fedora-release/pull-request/rpms/fedora-release/pull-request/22" which doesn't exists instead of redirecting to the existing PR URL which is "https://src.fedoraproject.org/rpms/fedora-release/pull-request/22". It duplicates the "pms/fedora-release/pull-request" string.


I wonder, does this affect all Pagure instances, or only src.fedoraproject.org? Because I've noticed a bunch of weirdnesses around PR linking there that don't happen on pagure.io.

  1. Linking in issue/PR comments with #3605 type links doesn't work there, it just shows up as plain text. (I'm guessing that 3605 will be linked, here.)
  2. PR entries in the activity calendar on user profiles aren't linked, see screenshot. On pagure.io profiles, they show up as links.

I don't have any PRs I can open on pagure, but I'm wondering if this is another issue that doesn't occur here.

Screenshot_from_2018-09-15_19-27-04.png

Yeah, I enabled PRs on my ferdnyc/pagure fork, then sent myself a branch-to-branch PR (admittedly not the best test), and the PR#1 green button link is fine.

It seems that a lot to do with internal linking on the src.fedoraproject.org Pagure instance is broken. Is there a best place to report that?

Screenshot_from_2018-09-15_19-40-59.png

It is a bug in pagure-dist-git which we are dropping in the next release, so let's check if it happens again once 5.0 is out :)

Metadata Update from @pingou:
- Issue tagged with: bug

6 months ago

Metadata Update from @pingou:
- Issue set to the milestone: Coming 3 months

3 months ago

Now that 5.x has been rolled out everywhere, have you seen this bug again?

I haven't tried it. Is there a staging instance to retry the steps? Also the UI is different now.

There are https://src.stg.fedoraproject.org and https://stg.pagure.io :)

And yes for the new UI, it was introduced in 5.0

It's sort of difficult to answer that question since the new UI does away with the green button in question (among many other changes) — and it doesn't appear to have any direct equivalent in the new interface.

Actually, the new UI doesn't appear to be picking up older PRs that predate its installation at all, unless I'm missing something. I have some still-open ones that it doesn't appear to know anything about. (Which is no big deal, really, it's just another reason why it's not easy to evaluate the status of this bug.)

I'm in the process of preparing a new PR that I'd been dragging my feet on submitting for a while, after I submit that (within the next few hours), I'll be able to see how PRs are tracked after being submitted in the new interface.

The place where you would see this is the "branch" page of the project, it should mimic the behaviour of the old list of branches on the right side.

I'm going to close this ticket as fixed.

Let's re-open it or open a new one if we run into issues with this again.

Thanks for your report!

Metadata Update from @pingou:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

2 months ago

Login to comment on this ticket.

Metadata