#3525 Pull Request: "Files changed" doesn't show all changes
Opened 5 years ago by nphilipp. Modified 5 years ago

I've recently filed https://pagure.io/rpkg/pull-request/372 and noticed that the "Files changed" tab doesn't show all changes in the PR. Specifically it's missing the changes contained in this patch/hunk:

From 06e1fce047acca6cf0c60f332a0c53be5f5d4991 Mon Sep 17 00:00:00 2001
From: Nils Philippsen <nils@redhat.com>
Date: Aug 20 2018 10:54:05 +0000
Subject: [PATCH 2/4] add missing method docstring


Signed-off-by: Nils Philippsen <nils@redhat.com>

---

diff --git a/tests/test_cli.py b/tests/test_cli.py
index 0b35694..b5939a6 100644
--- a/tests/test_cli.py
+++ b/tests/test_cli.py
@@ -2605,6 +2605,9 @@ State:    failed

     @patch.object(Commands, '_run_command')
     def test_module_build_local_mbs_manager_is_missing(self, mock_run):
+        """
+        Test submitting a local module build with mbs-manager missing #1.
+        """
         mock_run.side_effect = rpkgError('[Errno 2] No such file or directory')

         cli_cmd = [

Here's a diff over the whole PR on paste.fedoraproject.org and alternatively on pastebin.com (which doesn't expire).


I must say this is odd and annoying :(

Metadata Update from @pingou:
- Issue tagged with: bug

5 years ago

We have been able to replicate this in another PR, I think the underlying issue is in pygit2. Basically, when commits have the same date, sometime the order is messed up and messes up the diff as well. I think it relates to: https://github.com/libgit2/pygit2/issues/747

The way we fixed it, we "reworded" one of the commit a few seconds later to ensure the order was correct in the PR and in the submitter's own git repo. That fixed the diff for us.

We have had changes in pagure recently which I believe could have fix the issue reported here.

Have you faced this recently?

Login to comment on this ticket.

Metadata