#3488 re-do PR inline comments
Opened 5 years ago by ryanlerch. Modified a year ago

Currently, we are not using the new diff view on PRs (the one that is now on commits themselves) because of the inline comments.

Currently, the inline comments are linked to the line number of the patch that is generated for a PR, while the new diff view shows the line number of the file itself being changed. so that is item one

The second thing we can fix here is providing a little more context in the comment stream itself for inline comments. Maybe a few lines above and below for each inline comment. This will help also if the commit(s) in the PR have changed. We might also want to investigate if we can inform the user if a PR is rebased and an inline comment doest really apply to a line anymore.

Finally, in covering the above two items, we need to make sure somehow that older inline comments still work. we might need to fall back to the old view if there are comments in the old style or something like that.


Metadata Update from @ryanlerch:
- Issue marked as blocking: #3823

5 years ago

Metadata Update from @wombelix:
- Issue set to the milestone: 6.0

a year ago

Login to comment on this ticket.

Metadata