#3476 Missing requirements for testing
Closed: Fixed a year ago by sergiodj. Opened 2 years ago by sergiodj.

Pagure doesn't seem to list its package requirements for running tests. It would be extremely helpful if it did! So far, I could identify the following dependencies (on Debian testing):

python-nose
python-gdbm
redis-server

But I'm still seeing a few failures, and I'll have to investigate those to see if there are more dependencies that need to be installed.


The requirements.txt files are being updated among other in https://pagure.io/pagure/pull-request/3467 but that doesn't mean more changes aren't needed.

Metadata Update from @pingou:
- Issue tagged with: bug

2 years ago

On Tuesday, July 31 2018, Pierre-YvesChibon wrote:

The requirements.txt files are being updated among other in https://pagure.io/pagure/pull-request/3467 but that doesn't mean more changes aren't needed.

Yeah. I've just discovered that fedmsg may also be needed. I'll have
to package it for Debian before proceeding with the pagure packaging.
Unless there's an easy way to disable certain tests...

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

@sergiodj fedmsg was previously packaged in Debian. It was just very old...

@sergiodj fedmsg was previously packaged in Debian. It was just very old...

Yes, I know. I'll have to package it again. And it depends on some Python modules that need to be packaged, too. It'll take some time.

Is there anything else we should do about this ticket?

I think maybe adding redis-server in tests_requirements.txt may be enough (in a comment since it's not a python library), would it? (be enough)

On Friday, September 21 2018, Pierre-YvesChibon wrote:

pingou added a new comment to an issue you are following:
``
Is there anything else we should do about this ticket?

I think maybe adding redis-server in tests_requirements.txt may be enough (in a comment since it's not a python library), would it? (be enough)
``

I honestly haven't had much time to hack on Pagure lately. Is
"redis-server" the only missing dependency? I seem to remember needing
python-gdbm, which is also not listed in test_requirementes.txt.

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

I seem to remember needing python-gdbm, which is also not listed in
test_requirementes.txt.

I think this may be a build requirement for fedmsg, but it's not a dependency of
pagure itself

On Saturday, September 22 2018, Pierre-YvesChibon wrote:

pingou added a new comment to an issue you are following:
``

I seem to remember needing python-gdbm, which is also not listed in
test_requirementes.txt.

I think this may be a build requirement for fedmsg, but it's not a dependency of
pagure itself

I may be wrong, but ISTR needing to install it in order to run the tests.

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Metadata Update from @pingou:
- Issue set to the milestone: Coming 3 months

2 years ago

is this valid nowadays? I can run all the tests with podman containers and one of them installs the requirements with pip

Metadata Update from @sergiodj:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

a year ago

I closed it because apparently everything has been fixed now.

Login to comment on this ticket.

Metadata