#3469 Unable to add tags to a pull request
Closed: Fixed 5 years ago Opened 5 years ago by jflory7.

Summary

Unable to add tags to a pull request and "Update" button does not respond

Background

I tried to add tags to this pull request, but I was unable to. I selected the tags I wanted to use, but when I clicked the update button, there was no response from the UI to indicate anything happened.

Screenshot_2018-07-28_PR171_Switch_to_Antora_-_fedora-commops_-_Pagure.png

Details

I'm not sure when this issue first came up. I've been able to add tags to pull requests in this repository before (but only before they are merged).

Outcome

Successfully add tags to a pull request and show in sidebar after updating


@jflory7 Try uploading the screenshot in a comment. It should work then.

(I've had this issue happen for many, many, many issues)

Metadata Update from @pingou:
- Issue tagged with: bug

5 years ago

Metadata Update from @pingou:
- Issue assigned to pingou

5 years ago

From my tests it also seems to be fixed now.

Let us know if that's also the case for you and we'll close this ticket as Fixed :)

Metadata Update from @pingou:
- Issue set to the milestone: 5.1

5 years ago

@jflory7 is this still an issue in 5.0?

We do have logic in there that stops editing of metadata after something has been merged. This still happens in 5.0, but that would explain the difference in the past between your two documented attempts above to add / change tags.

Not sure why you can't edit tags after a merge, that logic was just in there, so i left it there when changing the UI around.

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #3821 Merged 5 years ago