#3446 Going https://pagure.io/pagure/stats#authors still opens Forks vies
Closed: Fixed 5 years ago Opened 5 years ago by abitrolly.

If I click https://pagure.io/pagure/stats#authors I get to forks view. Is there a documentation that explains how that can happen?

My understanding is that server should parse #authors from URL and send appropriate content, but there is also a JavaScript code that handles page clicks, and something is wrong with behaviour of these two. Is there a description of this pagure request processing?


My understanding is that server should parse #authors from URL and send appropriate content,

That'd be incorrect, the # isn't part of the URL's routing, so the server sends the default which is the list of forks.

We should add JS that checks on load the URL and refresh the pages based on the value after the '#'.

Metadata Update from @pingou:
- Issue tagged with: RFE

5 years ago

Does that mean pagure doesn't work without JavaScript at all?

Would it make sense to split the stats to separate pages so that server can tell the difference? The same could be done to settings page.

I like the idea of separate pages, because they can be used as API routes as well.

My understanding is that server should parse #authors from URL and send appropriate content,

That'd be incorrect, the # isn't part of the URL's routing, so the server sends the default which is the list of forks.
We should add JS that checks on load the URL and refresh the pages based on the value after the '#'.

I got this working pretty well on the new settings pages. there i think i covered all the bases of using the achcors like this...

TBH, i think forks should really move to a new tab in the new "Source" top level tab, rather than the stats top level tab. in the new UI.

That said, i need to update the stats tabs to look a little better and work better too. :)

Metadata Update from @ryanlerch:
- Issue assigned to ryanlerch

5 years ago

And does navigation work without JavaScript? :)

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #3502 Merged 5 years ago